Feature/q3 2023 updates

[fivetran-reneeli]

PR Overview

This PR will address the following Issue/Feature: n/a

This PR will result in the following new package version: v 11

Significant updates to our Stripe package for Q3 2023.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

• Addition of new Stripe report end models, plus updates to the balance transaction model
• Additional of new fields

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• [n/a] The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

Confirm that these additions appear in the target schema when run

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• [n/a] README updates have been applied (if applicable)
• DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

[fivetran-joemarkiewicz]

@fivetran-reneeli thanks for working through these changes. It seems that the most significant updates have been made to the balance transactions model which I can see being valuable to all users, not just the ones who will take advantage of these new reports!

I do have a number of requests for you to review and make appropriate updates.

Some major ones include my thoughts of renaming the fields in the staging models as opposed to the end model for consistency and allowing the focus of the transform models to be used for transformation purposes and not renaming. This also follows our intention of the source package. Following discussion with @fivetran-reneeli we will instead do the alias renaming in the final select statement. Updating the source will cause major scope creep although that is the preferred. Possibly we can open FR to make this update in the future.

Additionally, I wonder if we can consolidate the payout enhanced model with the balance transaction since they are almost identical. I would like to discuss those two in more detail before you move forward with updates.

See my other comments below and let me know if you have any questions. Thanks!

[fivetran-joemarkiewicz]

@fivetran-reneeli thanks for making these updates and the new models are looking really good! I just have a few final comments (see the previous comments for any unresolved ones that should be addressed as well).

Once these updates are applied, be sure to address the source package review notes and then regen the docs. This should then be good to roll out!

Lastly you may need to use a new schema for integration tests as it looks like the Snowflake schema has conflicting role permissions now and is resulting in failed buildkite jobs.

[fivetran-joemarkiewicz]

Thanks so much for working on these updates @fivetran-reneeli. This looks good to go to release review!

[fivetran-joemarkiewicz]

Bumping this reminder before merge