-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adding conversions #28
Conversation
packages.yml
Outdated
# - package: fivetran/snapchat_ads_source | ||
# version: [">=0.7.0", "<0.8.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_snapchat_ads_source.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just one question and a request to remove some commented out code.
dbt-databricks>=1.3.0,<2.0.0 | ||
|
||
oscrypto @ git+https://github.com/wbond/oscrypto.git@d5f3437 | ||
dbt-databricks>=1.6.0,<2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment from the source if there is a reason we had to use 1.6.0 and not 1.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same response from source, this is fine to keep
PR Overview
This PR will address the following Issue/Feature: Adding conversions project
This PR will result in the following new package version: 0.7.0
See CHANGELOG for why changes are breaking.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates: Conversion Support!
We have added more robust support for conversions in our data models by doing the following:
conversion_purchases_value
field to each_report
end model, representing the value of conversions that occurred on each day for each account, ad, ad squad, campaign and url.dbt_project.yml
to bring in the most used conversion fieldconversion_purchases
by default.total_conversions
metric in our end models to track all conversions being brought in by thesnapchat_ads_conversion_fields
variable.Documentation Update
snapchat_ads__conversion_fields
in the README.Under the Hood
persist_pass_through_columns()
macro in which we can includecoalesces
and properly check between conversion field values and the existing passthrough column.Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validated the new tests worked on both dev and integration tests
Integration tests run


Dev run


If you had to summarize this PR in an emoji, which would it be?
📱