Bugfix/update passthrough coulmns #38
Conversation
|
There was a problem hiding this comment.
@fivetran-reneeli thanks for working on this! I have a few change requests to update the PR and some comments. Let me know if you have any questions
| @@ -69,18 +75,22 @@ add_fields as ( | |||
| case when is_closed_this_quarter then 1 else 0 end as closed_count_this_quarter | |||
|
|
|||
| --The below script allows for pass through columns. | |||
| {{ custom_persist_pass_through_columns(pass_through_variable='salesforce__opportunity_pass_through_columns', identifier='opportunity') }} | |||
There was a problem hiding this comment.
We can probably use the normal version of the macro here.
| # - package: fivetran/salesforce_source | ||
| # version: [">=0.7.0", "<0.8.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_salesforce_source.git | ||
| revision: bugfix/update_passthrough_columns | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to update before merge
There was a problem hiding this comment.
@fivetran-reneeli we are almost to the finish line. There are a few errors I ran into. Would you be able to address them and then let me know once this is ready for review.
|
|
||
| {% if var('product_2_pass_through_columns',[]) != [] %} | ||
| , product_2.{{ var('product_2_pass_through_columns') | join (", product_2.")}} | ||
| {{ fivetran_utils.persist_pass_through_columns(pass_through_variable='salesforce__opportunity_line_item_pass_through_columns', identifier='opportunity_line_item') }} |
There was a problem hiding this comment.
When I try to pass a variable through here I get the following error.
This needs to refer to the identifier of the table below. Since it is being aliased we need to properly add the alias here for the identifier.
|
PR Overview
This PR will address the following Issue/Feature:
Zendesk created ticket
This PR will result in the following new package version:
v0.9.0 - breaking change if users choose to use the alias feature to change field names
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
updates the old passthrough column methodology to allow for aliasing of any field names brought in. This is useful, for example, if you wish to bring in fields across different Salesforce objects that may have the same names and wish to alias them to avoid confusion, particularly if any of the objects are joined together.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
configs specified in internal ticket
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🚜