Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/order to orders #12
Feature/order to orders #12
Changes from 7 commits
f891ae9
1e05579
5fdcbab
c0ee188
d9151d1
f5d9e15
66f236e
3699eb0
50da75d
b4d0968
d8426f2
476b2a9
f08255f
eeba659
53cedf9
59cd15b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we disable this source based on
recharge__using_orders
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially also using the
recharge_does_table_exist
macro if possibleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie I hand't considered that, so I'm flexible either way! Could you explain the benefits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! Not much since we don't have any freshness tests in this package haha
Only benefit I can think of is getting rid of a floating
orders
source entity in the DAG for people who don't have it yet. Not super high priority, especially given that there's not an easy way to get rid of a floatingorder
source in the DAG for people withorders
.Honestly let's leave it as is. I feel like it's more beneficial to potentially call people's attention to the upcoming
ORDERS
transition