Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add union data #123
base: main
Are you sure you want to change the base?
Feature/add union data #123
Changes from all commits
63ecab2
b668a58
e35e9eb
9caf6ad
93ca4f3
ea142f4
4e390b5
0644b82
b6900a5
1f7cda8
c8c51da
7b2a5ca
7a37bb8
363527b
ad0c752
7ef069f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the need for this addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment applies to the other models with the similar code update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah essentially we don't want to include
_dbt_source_relation
(which is created byunion_data
/union_relation
) in theremove_prefix_from_columns
macro call.without adding it to the
exclude
list, users passing through all columns would end up with both asource_relation
and_dbt_source_relation
column, which is redundant and a lil confusing. thus, this change makes sure that these users just have the more-nicely-namedsource_relation
field.