Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ctes to standards #85

Merged
merged 4 commits into from
Aug 8, 2023
Merged

rename ctes to standards #85

merged 4 commits into from
Aug 8, 2023

Conversation

fivetran-reneeli
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature: #84

This PR will result in the following new package version: v1.0.1

Doesn't affect any downstream or end model output. Everything is under the hood

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Rename the CTEs in staging models to our current package standards (base, fields, final)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Nothing downstream is impacted. Very cosmetic change to the names of CTES to follow our package standards and avoid potential recursive references.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • [ n/a] README updates have been applied (if applicable)
  • [ n/a] DECISIONLOG updates have been updated (if applicable)
  • [ n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli self-assigned this Aug 7, 2023
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this update. Your changes look good to go! I just have one small suggestion to consolidate the changelog entries into one.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Markiewicz <[email protected]>
@fivetran-reneeli fivetran-reneeli merged commit a65c7c4 into main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants