-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this should fix the issue below #67
this should fix the issue below #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lord-skinner thanks so much for opening this PR and fixing the join to account for these situations! The update you applied here makes sense and looks good to move forward with in the next release of the package.
A few quick requests to apply to the PR before approving:
- Would you be able to update the version index in the
dbt_project.yml
and theintegraiton_tests/dbt_project.yml
files. For this update it should change to0.6.4
- Would you be able to update the CHANGELOG.md file to include this new version and the change you are submitting. Don't forget to include yourself as a contributor!
Once those updates are applied, I will approve your PR and merge it into a staging branch for us to apply some backend testing and docs updates before merging into main
and releasing. Let me know if you have any questions!
Commited requested changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lord-skinner thanks so much for opening this PR to address your initial issue you identified!
The updates you applied look good to me and we can move forward with merging into a staging branch. The staging branch is only intended for me to apply some behind the scenes testing updates before merging into main
and releasing.
I will be sure to link the PR to main
in this thread so you will be able to track it. I would expect a release of this package early next week!
dacd4e9
into
fivetran:customer/lord-skinner-update
#66
Pull Request
Are you a current Fivetran customer?
Matthew Skinner, Data Architect, Elastic, Inc
What change(s) does this PR introduce?
fixes the join clause
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood