Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config enabled for disable-able sources #58

Merged

Conversation

epapineau
Copy link
Contributor

@epapineau epapineau commented Aug 3, 2022

Pull Request
Are you a current Fivetran customer?

Elize Papineau, Senior Analytics Engineer, dbt Labs
Yes, working on behalf of a customer using Fivetran
What change(s) does this PR introduce?

Passes the configurable variables to config: enabled to prevent running source freshness on disabled models
Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)
    It extends use of existing variables
    Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

😷

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@epapineau epapineau marked this pull request as ready for review August 3, 2022 00:28
@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Aug 3, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epapineau thanks so much for making these changes! They look great on my end, but I actually just discovered that there is a native way we can disable these sources without needing to use the meta config and override the freshness macro!

The best option would be to disable the source entirely instead of the meta config. Thankfully, the only change needed in your PR is to swap meta for config. Would you be able to make those changes and see if they work as intended on your end?

models/staging/src_fivetran_log.yml Outdated Show resolved Hide resolved
@epapineau epapineau changed the title Add meta is_enabled for disable-able sources Add config enabled for disable-able sources Aug 3, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epapineau thanks so much for making the changes 😄 I made two small changes to bump the version in our integration tests project and also made a small edit to the CHANGELOG.

With that, this PR is good to go! Thanks so much for your collaboration and contribution to the package 🙌 These packages are made better by contributors like yourself adding to the code base. I will merge this and plan to cut a release later this morning.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit a3addfd into fivetran:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants