-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds options to which models are included #52
Conversation
bumped the version number to 0.5.5
added flag to disable this model build if required
Added option to disable this model
Added option to disable this model
Added option to disable this model
Added option to disable this model
Added option to disable this model
Added option to disable model
Updated description for 0.5.5
Hey @cmcau thanks so much for opening this PR!! These changes make complete sense and I understand why you would want to remove these models from the run as they do not exist during the trial phase. My one question I have is regarding the value of the end models with these disabled. Are you still able to gain actionable insights in your opinion with these disabled? |
Well, I don't know what I'm missing right ? ;) Active Volume seems to be the most interesting one that I'm missing (but I'm only going on the name of the model) |
@cmcau thanks again for opening this PR! I am going to be pushing a few changes to the PR you have in place to fold into the Further, I believe these models should be synced even when you are on the free trial. Please let me know if this was not your experience. |
Pull Request
Are you a current Fivetran customer?
Partner
Chris McClellan
Director
Visualisedata Pty Ltd
AUSTRALIA
What change(s) does this PR introduce?
Adds options to dbt_project.yml to optionally load some of the models. I wanted to use this package to show what Fivetran was doing (during the trial period), but some of the models are not available and that causes an error. With these changes I don't get any errors and I can report on the data because the run finishes without any errors
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
I'm going to say YES to be safe. I only thought of that now - if users don't have the vars defined then there will be an error I guess. I haven't tested this, but I'm happy to do the work if this is an issue that needs to be fixed and this PR is going to benefit the package.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
I tested it with all the vars properly defined in the root dbt_project.yml and it passed all tests.
I DID NOT test when the vars are not defined in the root dbt_project.yml
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
😀 hopefully, but a lot of 😟 at the same time
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.