-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/transformation log and changelog test #51
Merged
fivetran-joemarkiewicz
merged 9 commits into
main
from
bugfix/transformation-log-and-changelog-test
Apr 20, 2022
Merged
Bugfix/transformation log and changelog test #51
fivetran-joemarkiewicz
merged 9 commits into
main
from
bugfix/transformation-log-and-changelog-test
Apr 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
…//github.com/fivetran/dbt_fivetran_log into bugfix/transformation-log-and-changelog-test
fivetran-jamie
requested changes
Apr 18, 2022
fivetran-jamie
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
This PR makes two notable changes:
unique_combination_of_columns
schema test for thefivetran_log__schema_changelog
model has been adjusted to also account for themessage_data
field. This adjustment is necessary as the Fivetran Log connector has been modified to sync multiple records at the same time. Therefore, multiple schema changes may come in at the same time. Therefore, we now want to look at the actual change for uniqueness as well.fivetran_log__connector_status
model fails due to JSON parsing not being able to be performed on non-JSON fields (this is only occurring in Snowflake instances). It was found that these non-JSON fields are limited only toTRANSFORMATIONS
event_subtypes. Since transformation logs are not needed in this model in the first place, an adjustment has been made to filter the records out before further modeling takes place.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
This is a bug fix that will not impact existing customers package runs.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
This succeeded on my local branch as well as customers in addition to CircleCi.
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🧪
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.