Feature/pricing update 2 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
…n/dbt_fivetran_log into feature/pricing-update-2
fivetran-joemarkiewicz
requested changes
Apr 19, 2022
There was a problem hiding this comment.
Looks good and thanks for your hard work on this update! I did have a few quick updates that we should apply before this can be approved.
- Minor update to the CHANGELOG. See comments in line
- Regenerate the dbt docs
- Version index seems off. Should it instead by
0.6.0?
…n/dbt_fivetran_log into feature/pricing-update-2
fivetran-joemarkiewicz
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
The updates look great! Thanks so much @fivetran-reneeli 🙌
Remember that we will hold off merging this until later.
|
An update we will want to make with this before release is adopt a new methodology to incorporate BOTH amount and credits used in the final model instead of just doing either or. |
…n/dbt_fivetran_log into feature/pricing-update-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Internal
What change(s) does this PR introduce?
Updates package to reflect to new pricing update and corresponding new
usage_costtable existing in users on the new pricing model. See #44 for more.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Shouldn't impact users on older pricing model and for users on new pricing model this should be net new. But I updated the version by +0.1.0 since it's pretty big
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.