bugfix/string-agg-removal

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: Issue #118

This PR will result in the following new package version: v1.7.0

This will be a breaking change as we are removing fields from an end model and could cause downstream errors with their removal.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨: Bug Fixes

• The following fields have been deprecated (removed) as these fields proved to be problematic across warehouses due to the end size of the fields.
  • errors_since_last_completed_sync
  • warnings_since_last_completed_sync

Note: If you found these fields to be relevant, you may still reference the error/warning messages from within the underlying log table.

• The fivetran_platform_using_sync_alert_messages variable has been removed as it is no longer necessary due to the above changes.

Feature Updates

• The following fields have been added to display the number of error/warning messages sync last completed sync. These fields are intended to substitute the information from deprecated fields listed above.
  • number_errors_since_last_completed_sync
  • number_warnings_since_last_completed_sync

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Please see the corresponding Height ticket for a link to the Hex document that includes the Hex validations notebook.

If you had to summarize this PR in an emoji, which would it be?

🔢

[fivetran-reneeli]

Reviewed with a few suggestions/ question!

[fivetran-joemarkiewicz]

Thanks @fivetran-reneeli for the quick and thoughtful review! I just addressed your comments and committed your suggestions. Thanks for catching my spelling mistakes 🤦. I also addressed the open question you had and will hold off regenerating the docs until approval.

[fivetran-reneeli]

Thanks @fivetran-joemarkiewicz , just responded above!

[fivetran-joemarkiewicz]

@fivetran-reneeli thanks again! I agree with your comment and just applied the changes and regenerated the docs. Let me know if you have any other comments.

[fivetran-reneeli]

lgtm