-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/redshift-large-int #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-catfritz
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: fivetran-catfritz <[email protected]>
Co-authored-by: Jamie Rodriguez <[email protected]>
Co-authored-by: Jamie Rodriguez <[email protected]>
fivetran-jamie
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Internally raised issue
This PR will result in the following new package version:
v1.6.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Breaking Changes
fivetran_platform__audit_table
model have been updated to be cast asdbt.type_bigint()
(previously wasdbt.type_int()
)sum_rows_replaced_or_inserted
sum_rows_updated
sum_rows_deleted
Bug Fixes
fivetran_platform__connector_daily_events
model have been updated to be cast asdbt.type_bigint()
(previously wasdbt.type_int()
)count_api_calls
count_record_modifications
count_schema_changes
Under the Hood
log
seed data within the integration tests folder to ensure a large integers are being tested as part of our integration tests.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
I was able to reproduce this error locally by editing the seed data to insert a
count
record in themessage_data
field within thelog
data to be a large integer that exists outside the normal range (Integer valid range -2147483648 to 2147483647). See the below screenshot where I was able to reproduce this error using the live version of the package.Additionally, I was able to see this error be resolved when using this branch version of the package.
Lastly, we can see the resulting audit_table and connector_daily_events end model fields look as we would expect following these updates.
Following these validations, I feel comfortable this should address the issue being reported for the integers being out of range for the respective fields.
If you had to summarize this PR in an emoji, which would it be?
🔢