Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/redshift json parse #114
Bug/redshift json parse #114
Changes from 32 commits
d7c0319
3fd8796
548f017
4ec7578
d489457
85689b7
1709d45
480c346
77978d3
5a80eac
9ffff41
1d8b875
c76acf1
b05ec50
32b9428
193b665
1c6a764
dfc7ad5
2ec773f
be958da
6d2d1e1
1aaeb0f
bcbe017
075b720
5a0e356
5384a99
c90d51d
24cc4fc
205ce6a
b5ad8e9
5aa991a
a6b7406
ac435aa
d4d85fd
01f0612
dae512d
dd75c37
2618f01
41e0792
6a69d61
f50c281
3dfecb7
675f56a
ea57b23
d26da8a
0fca474
56b1214
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a strange question, but what scenario would we need a default_start_date? Shouldn't there always by a
max(date)
on incremental runs? What scenario would there be where we need the coalesce to select the default start date?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I trialed removing this and it seems to compile and run fine. However for now I will leave this pending discussion on Tuesday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I just wanted to make sure there likely wouldn't be a scenario where this field would actually be
null
. I don't believe including it will hurt so I am comfortable leaving it in.