Add deleted connector statuses to fivetran_platform__connector_status
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Jan 22, 2024
There was a problem hiding this comment.
@fivetran-avinash thanks for working through this PR! This is looking great, I just have a few considerations that we should apply before being approved. Let me know if you have any questions. Thanks!
There was a problem hiding this comment.
@fivetran-joemarkiewicz Changes applied! Ran into an error re: SQL Server, but resolved it I think.
fivetran-joemarkiewicz
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
@fivetran-avinash thanks for making the requested changes. This looks good to go with just one small suggestion to simplify the conditional logic in the staging model.
| @@ -25,7 +25,8 @@ final as ( | |||
| destination_id, | |||
| connecting_user_id, | |||
| paused as is_paused, | |||
| signed_up as set_up_at | |||
| signed_up as set_up_at, | |||
| coalesce(_fivetran_deleted, {% if target.type == 'sqlserver' %} 0 {% else %} false {% endif %}) as is_deleted | |||
There was a problem hiding this comment.
small suggestion to consolidate the conditional code here.
Suggested change
| coalesce(_fivetran_deleted, {% if target.type == 'sqlserver' %} 0 {% else %} false {% endif %}) as is_deleted | |
| coalesce(_fivetran_deleted,{{ ' 0 ' if target.type == 'sqlserver' else ' false'}}) as is_deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#108]
This PR will result in the following new package version: 1.4.3
Column added in a staging model does not cause breaking changes.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
connector_healthdimension infivetran_platform__connector_statusto showdeletedfor connectors that had been removed. Previously the connector would report the last known status before deletion, which is inaccurate based on the definition of this measure.is_deleteddimension (based on the_fivetran_deletedvalue) tostg_fivetran__platform__connectorto capture connectors that are deleted in the downstreamfivetran_platform__connector_statusmodel.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps: See Height ticket.
If you had to summarize this PR in an emoji, which would it be?
🍵