-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Add limit 0 to credits_used
and usage_cost
to fix Postgres errors
#109
Conversation
credits_used
and usage_cost
to fix Postgres errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash thanks for working through this! This is looking good, but I have a few comments and suggestions below. Let me know if you have any questions - we can sync on the SQL Server one in more detail next week, but you should be able to start building out the bones of a conditional knowing SQL Server likely doesn't support the limit
function.
@fivetran-joemarkiewicz Changes applied and ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash these changes look great to me, thanks for applying them! I have approved the PR as your changes look good, but I would like to hold off merging and releasing until we can get the sqlserver warehouse back up and running to fully test.
Once Buildkite is passing on the soon to be recreated sqlserver warehouse, we can initialize the release review process.
…com/fivetran/dbt_fivetran_log into bugfix/date-casting-on-credits-used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! With one suggestion in order to get BK passing.
PR Overview
This PR will address the following Issue/Feature: [#104]
This PR will result in the following new package version: 1.4.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
stg_fivetran_platform__credits_used
andstg_fivetran_platform__usage_cost
to return empty tables if the respectivefivetran_platform__credits_pricing
and thefivetran_platform__usage_pricing
variables for each model are disabled to avoid Postgres data type errors if those tables are null.Under the Hood
run_models.sh
for the package with the variablesfivetran_platform__credits_pricing
set to false andfivetran_platform__usage_pricing
set to true to recreate the error.fivetran_platform__usage_mar_destination_history
for validating this PR.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See Height ticket
If you had to summarize this PR in an emoji, which would it be?
💳