Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Databricks SQL Warehouse Compatibility #120

Closed
2 of 4 tasks
fivetran-joemarkiewicz opened this issue Apr 1, 2024 · 2 comments
Closed
2 of 4 tasks

[Bug] Databricks SQL Warehouse Compatibility #120

fivetran-joemarkiewicz opened this issue Apr 1, 2024 · 2 comments
Assignees
Labels
error:forced priority:p2 Affects most users; fix needed status:in_review Currently in review type:bug Something is broken or incorrect update_type:models Primary focus requires model updates

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Apr 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

If a user is leveraging the a Databricks SQL Warehouse, then they will see the below error. This is due to the incremental strategy insert_overwrite not being compatibile with Databricks SQL Warehouse runtimes.

Relevant error log or model output

spark.sql.sources.partitionOverwriteMode is not available

Expected behavior

The incremental strategy works regardless of Databricks runtime.

dbt Project configurations

Any

Package versions

Latest

What database are you using dbt with?

databricks

dbt Version

Any

Additional Context

We likely will consider the following since we cannot differentiate between databricks runtimes in dbt when using adapter calls.

  • Leverage the merge strategy with some failsafes in place to avoid the downsides of the merge strategy

  • Remove the incremental strategy

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p2 Affects most users; fix needed type:bug Something is broken or incorrect status:scoping Currently being scoped update_type:models Primary focus requires model updates error:forced labels Apr 1, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Apr 2, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz added status:in_progress Currently being worked on and removed status:scoping Currently being scoped labels Apr 2, 2024
@fivetran-joemarkiewicz
Copy link
Contributor Author

Providing an update here - we have been able to find a way to differentiate between Databricks SQL Warehouse and Databricks All Purpose Clusters in the above PR! I had gone back and forth on either leveraging the merge strategy or just opting to remove the incremental strategy for SQL Warehouse runtimes. As we are not 100% confident in the merge incremental strategy for the fivetran_platform__audit_table model at this time, we are moving forward with making this model not incremental for SQL Warehouse Databricks runtimes.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added status:in_review Currently in review and removed status:in_progress Currently being worked on labels Apr 3, 2024
@fivetran-joemarkiewicz
Copy link
Contributor Author

As of the latest release v1.7.2, this compatibility issue has been addressed. As such, I will close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:forced priority:p2 Affects most users; fix needed status:in_review Currently in review type:bug Something is broken or incorrect update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

1 participant