-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation/basic-ad-update #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-catfritz
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
fivetran-catfritz
approved these changes
Nov 6, 2023
fivetran-catfritz
approved these changes
Nov 6, 2023
fivetran-data-model-bot
requested review from
a team,
fivetran-jamie and
fivetran-avinash
and removed request for
a team
November 6, 2023 22:58
fivetran-data-model-bot
requested review from
a team and
fivetran-reneeli
and removed request for
a team
November 6, 2023 23:00
@fivetran-joemarkiewicz Hey really really really sorry I accidentally committed to your branch... I undid it though so you can ignore. |
fivetran-reneeli
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
fivetran-data-model-bot
requested review from
a team and
fivetran-avinash
and removed request for
a team
November 7, 2023 22:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #26 and #35
This PR will result in the following new package version:
v0.7.1
This will not be a breaking change as this only updates documentation.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Documentation Updates
basic_ad
pre-built report have been modified to reflect the current state of the Facebook Ads connector.Additional updates
main
.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
In order to validate these steps I went through the creation of a new Facebook Ads connector
facebook_ads_basic_ad_test
and confirmed thebasic_ad
pre-built report is now synced by default and if you wish to enable/disable the table you will do so via the schema tab.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🏗️