feature/enable-null-urls #72
Conversation
There was a problem hiding this comment.
hey @fivetran-catfritz, looks mostly good! Just some minor updates before merge.
Once you are able to get buildkite passing, and docs regenerated, please feel free to merge.
CHANGELOG.md
Outdated
| @@ -1,3 +1,15 @@ | |||
| ## 🎉 Features 🎉 | |||
| - Added ability for a user to allow records having nulls in url fields to be included in the `ad_reporting__url_report` and/or the underlying `...url_report` models. This is done by setting the below variable to `False` in your `dbt_project.yml` file. | |||
There was a problem hiding this comment.
you can use the wildcard asterisk to denote all url reports:
*url_report
There was a problem hiding this comment.
and also, remember to cite the PR here!
CHANGELOG.md
Outdated
| ## 🚘 Under the Hood 🚘 | ||
| - Disabled the `not_null` test for `ad_reporting__url_report` when null urls are allowed. [#72](https://github.com/fivetran/dbt_ad_reporting/pull/72) | ||
|
|
||
|
|
There was a problem hiding this comment.
remember to move the above section into the migrations changelog entry!
packages.yml
Outdated
| @@ -8,47 +8,47 @@ packages: | |||
| # - package: fivetran/snapchat_ads | |||
| # version: [">=0.5.0", "<0.6.0"] | |||
| - git: https://github.com/fivetran/dbt_snapchat_ads.git | |||
| revision: MagicBot/dbt-utils-cross-db-migration | |||
| revision: feature/enable-null-urls | |||
There was a problem hiding this comment.
reminder to switch revisions once all upstream packages have been merged with the migration branch!
|
I am going to merge this even though it is still failing databricks. It's the same issue we have been seeing in Google Ads and I believe once that is resolved, this will pass. Oddly, removing it from integration testing is still not completely solving the problem. |
Are you a current Fivetran customer?
Fivetran created PR.
What change(s) does this PR introduce?
ad_reporting__url_reportmodel.not_nulltest forpinterest_ads__url_reportwhen null urls are allowedDid you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🍝
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.