Skip to content

Commit

Permalink
Feature/linkedin click uri updates (#120)
Browse files Browse the repository at this point in the history
* feature/linkedin-click-uri-updates

* docs regen and integration schema change

* changelog update

* integration test merge conflict address

* changelog fix

* another changelog fix
  • Loading branch information
fivetran-joemarkiewicz authored Dec 10, 2024
1 parent 35f44d4 commit ff499b8
Show file tree
Hide file tree
Showing 9 changed files with 148 additions and 129 deletions.
20 changes: 16 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,29 @@
# dbt_ad_reporting v1.11.0

[PR #127](https://github.com/fivetran/dbt_ad_reporting/pull/127) includes the following updates:

## Breaking Changes
### LinkedIn Ads
- The dependency on dbt_linkedin has been bumped to the `[">=0.10.0", "<0.11.0"]` range and the dbt_linkedin_source dependency has been bumped to the `[">=0.10.0", "<0.11.0"]` range. These upstream version ranges include the following breaking changes. For more details regarding these changes, refer to the [dbt_linkedin_source v0.10.0](https://github.com/fivetran/dbt_linkedin_source/releases/tag/v0.10.0) and [dbt_linkedin v0.10.0](https://github.com/fivetran/dbt_linkedin/releases/tag/v0.10.0) release notes. ([PR #120](https://github.com/fivetran/dbt_ad_reporting/pull/120))
- The `click_uri_type` field has been added to the below mentioned models. This field allows users to differentiate which click uri type (`text_ad` or `spotlight`) is being used to populate the results of the `click_uri` field.
- `stg_linkedin_ads__creative_history`
- `linkedin_ads__creative_report`
- `linkedin_ads__url_report`
- Please be aware this new field only supports `text_ad` or `spotlight` click uri types. If you are interested in this package supporting more click uri ad types, please let us know in this [Feature Request](https://github.com/fivetran/dbt_linkedin_source/issues/70).
- The `click_uri` field has been adjusted to populate the results following a coalesce on the `text_ad_landing_page`, `spotlight_landing_page`, or `click_uri` fields. For more details refer to [dbt_linkedin_source v0.10.0](https://github.com/fivetran/dbt_linkedin_source/releases/tag/v0.10.0) release notes. ([PR #120](https://github.com/fivetran/dbt_ad_reporting/pull/120))
- This change is in response to a [LinkedIn Ads API](https://learn.microsoft.com/en-us/linkedin/marketing/community-management/contentapi-migration-guide?view=li-lms-2024-05#adcreativesv2-api-creatives-api) and [Fivetran LinkedIn Ads connector update](https://fivetran.com/docs/connectors/applications/linkedin-ads/changelog#january2024) which moved `click_uri` data to either the `text_ad_landing_page` or `spotlight_landing_page` fields depending on the creative type.

### tiktok_ads
- In the [July 2023 update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023) for the `ADGROUP_HISTORY` table, the `age` column was renamed to `age_groups`.
- In the [July 2023 update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023) for the `ADGROUP_HISTORY` table, the `age` column was renamed to `age_groups`. ([PR #127](https://github.com/fivetran/dbt_ad_reporting/pull/127))
- Previously in `dbt_tiktok_source`, we coalesced these two columns in the `stg_tiktok_ads__ad_group_history` model to account for connectors using the old naming convention. However, due to inconsistent data types, we can no longer use this approach.
- As a result, the coalesced field has been removed in favor of the `age_groups` column.
- If necessary, you can populate historical data in the `age_groups` column by performing a resync of the `ADGROUP_HISTORY` table, since TikTok provides all data regardless of the previous sync state.
- For more details, see the [DECISIONLOG entry](https://github.com/fivetran/dbt_tiktok_ads_source/blob/main/DECISIONLOG.md).

# dbt_ad_reporting v1.10.0
## Under the Hood
- Addition of the following consistency validation tests for the below mentioned models to be used during integration tests (only used by Fivetran maintainers):
- `ad_reporting__ad_report`
- `ad_reporting__url_report`

# dbt_ad_reporting v1.10.0
[PR #122](https://github.com/fivetran/dbt_ad_reporting/pull/122) introduces the following **BREAKING CHANGES:**

## Feature Updates: Native Conversion Support
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -564,10 +564,10 @@ packages:
version: [">=0.11.0", "<0.12.0"]
- package: fivetran/linkedin
version: [">=0.9.0", "<0.10.0"]
version: [">=0.10.0", "<0.11.0"]
- package: fivetran/linkedin_source
version: [">=0.9.0", "<0.10.0"]
version: [">=0.10.0", "<0.11.0"]
- package: fivetran/microsoft_ads
version: [">=0.9.0", "<0.10.0"]
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ dispatch:
models:
+schema: "ad_reporting_{{ var('directed_schema','dev') }}"

vars:

vars:
apple_search_ads__using_search_terms: True
twitter_ads__using_keywords: False

Expand Down Expand Up @@ -613,6 +612,10 @@ seeds:
+column_types:
created_time: timestamp
last_modified_time: timestamp
status: "{{ 'string' if target.type in ['bigquery','spark','databricks'] else 'varchar' }}"
intended_status: "{{ 'string' if target.type in ['bigquery','spark','databricks'] else 'varchar' }}"
last_modified_at: timestamp
created_at: timestamp
linkedin_ad_analytics_by_campaign_data:
+column_types:
day: timestamp
Expand Down
Loading

0 comments on commit ff499b8

Please sign in to comment.