Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Adding Types to passable 👓 #106

Merged
merged 9 commits into from
Jan 30, 2019
Merged

[FEATURE] Adding Types to passable 👓 #106

merged 9 commits into from
Jan 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2019 •
edited by ghost
Loading

Improving the Developers experience when using Passable with VSCode even in JS files! 🎉

typedpassable

I took the documentation from Passable website and I'm sure that many will happily enjoy reading it inline 😃

I also used the advanced typing of Record in TypeScript but the autocomplete wasn't that good to inspect so I've used the regular types syntax to make it with high-quality as possible

TODOs

  • Support more usages:

    image

@ghost ghost self-assigned this Jan 28, 2019
@ghost ghost requested review from michael5r and ealush January 28, 2019 20:53
@ghost ghost requested review from raphaelboukara and sahariko as code owners January 28, 2019 20:53
@ghost ghost changed the title [WIP] Adding Types to passable [FEATURE] Adding Types to passable Jan 28, 2019
@ghost ghost changed the title [FEATURE] Adding Types to passable [FEATURE] Adding Types to passable 🎉 Jan 28, 2019
@ghost ghost mentioned this pull request Jan 28, 2019
Merged
@ghost ghost changed the title [FEATURE] Adding Types to passable 🎉 [WIP] Adding Types to passable 🎉 Jan 29, 2019
@ghost ghost changed the title [WIP] Adding Types to passable 🎉 [FEATURE] Adding Types to passable 🎉 Jan 29, 2019
@ghost ghost changed the title [FEATURE] Adding Types to passable 🎉 [FEATURE] Adding Types to passable 👓 Jan 29, 2019
@ealush ealush changed the base branch from master to next January 30, 2019 10:07
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
ealush
ealush reviewed Jan 30, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ghost ghost force-pushed the 2019_01_28_addTypes branch from c806fef to 3495828 Compare January 30, 2019 14:08
@ealush
Copy link
Contributor

ealush commented Jan 30, 2019

Thank you, @Attrash-Islam!

@ealush ealush merged commit 82c0a40 into next Jan 30, 2019
@ghost ghost mentioned this pull request Jan 30, 2019
Merged
ealush pushed a commit that referenced this pull request Jan 31, 2019
@ealush
[MINOR] Add more types 👓 (#109)
2806180 
Ref -> #106

![jan-30-2019 20-02-37](https://user-images.githubusercontent.com/7091543/52002194-05c06780-24ca-11e9-89cf-06dd41be3a8e.gif)
@ealush ealush deleted the 2019_01_28_addTypes branch May 10, 2019 12:02
@ghost ghost mentioned this pull request Jun 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael5r michael5r Awaiting requested review from michael5r

@raphaelboukara raphaelboukara Awaiting requested review from raphaelboukara

@sahariko sahariko Awaiting requested review from sahariko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ealush