Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for headers and query params to workflow invocations #97

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Add support for headers and query params to workflow invocations #97

merged 2 commits into from
Jan 22, 2018

Conversation

erwinvaneyk
Copy link
Member

@erwinvaneyk erwinvaneyk commented Jan 21, 2018 •
edited
Loading

This PR Additionally...

  • centralizes the typedvalue <-> fission request logic in request.go
  • refactored header input values from header_* to headers syntax
  • adds some tests for the conversion

Fixes #96

@erwinvaneyk
Add support for headers and query params to workflow invocations
b07c045 
Additionally:

- Extracted typedvalue<->fission request logic

- Refactored header input values from header_* to headers syntax
@erwinvaneyk
Added examples on how to reference request metadata
a69e300
@erwinvaneyk erwinvaneyk merged commit 850d481 into master Jan 22, 2018
@erwinvaneyk erwinvaneyk deleted the workflow-env-headers branch January 22, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erwinvaneyk