Add go vet check to project

.travis.yml

@@ -7,10 +7,11 @@ install:
 - go get github.com/Masterminds/glide
 - go get github.com/nats-io/nats-streaming-server
 script:
+- hack/verify-gofmt.sh
+- hack/verify-govet.sh
 - cd ${TRAVIS_BUILD_DIR}
 - glide install
 - ./build/build-linux.sh
-- hack/verify-gofmt.sh
 - test/runtests.sh
 notifications:
   slack:

cmd/fission-workflows-bundle/bundle/bundle.go

@@ -131,7 +131,7 @@ func Run(ctx context.Context, opts *Options) error {
 
 	// Http servers
 	if opts.Fission != nil {
-		proxySrv := http.Server{Addr: FISSION_PROXY_ADDRESS}
+		proxySrv := &http.Server{Addr: FISSION_PROXY_ADDRESS}
 		defer proxySrv.Shutdown(ctx)
 		runFissionEnvironmentProxy(proxySrv, es, wfiCache(), wfCache(), resolvers)
 	}
@@ -159,7 +159,7 @@ func Run(ctx context.Context, opts *Options) error {
 	}
 
 	if opts.ApiHttp {
-		apiSrv := http.Server{Addr: API_GATEWAY_ADDRESS}
+		apiSrv := &http.Server{Addr: API_GATEWAY_ADDRESS}
 		defer apiSrv.Shutdown(ctx)
 		var admin, wf, wfi string
 		if opts.ApiAdmin {
@@ -292,7 +292,7 @@ func runWorkflowInvocationApiServer(s *grpc.Server, es fes.EventStore, wfiCache
 	log.Infof("Serving workflow invocation gRPC API at %s.", GRPC_ADDRESS)
 }
 
-func runHttpGateway(ctx context.Context, gwSrv http.Server, adminApiAddr string, wfApiAddr string, wfiApiAddr string) {
+func runHttpGateway(ctx context.Context, gwSrv *http.Server, adminApiAddr string, wfApiAddr string, wfiApiAddr string) {
 	mux := grpcruntime.NewServeMux()
 	grpcOpts := []grpc.DialOption{grpc.WithInsecure()}
 	if adminApiAddr != "" {
@@ -325,7 +325,7 @@ func runHttpGateway(ctx context.Context, gwSrv http.Server, adminApiAddr string,
 	log.Info("Serving HTTP API gateway at: ", gwSrv.Addr)
 }
 
-func runFissionEnvironmentProxy(proxySrv http.Server, es fes.EventStore, wfiCache fes.CacheReader,
+func runFissionEnvironmentProxy(proxySrv *http.Server, es fes.EventStore, wfiCache fes.CacheReader,
 	wfCache fes.CacheReader, resolvers map[string]function.Resolver) {
 
 	workflowParser := parse.NewResolver(resolvers)

hack/verify-govet.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+set -o errexit
+set -o nounset
+set -o pipefail
+
+find_files() {
+  find . -not \( \
+      \( \
+        -wholename '*/vendor/*' \
+      \) -prune \
+    \) -name '*.go'
+}
+
+find_files | grep -v '.glide/cache' | xargs -I@ bash -c "go tool vet @"

pkg/fes/eventstore/nats/client.go

@@ -140,6 +140,6 @@ func toEvent(msg *stan.Msg) (*fes.Event, error) {
 		return nil, err
 	}
 
-	e.Id = fmt.Sprintf("%s", msg.Sequence)
+	e.Id = fmt.Sprintf("%d", msg.Sequence)
 	return e, nil
 }

pkg/util/util.go

@@ -27,7 +27,7 @@ func CreateScopeId(parentId string, taskId string) string {
 }
 
 // Wait is a sync.WaitGroup.Wait() implementation that supports timeouts
-func Wait(wg sync.WaitGroup, timeout time.Duration) bool {
+func Wait(wg *sync.WaitGroup, timeout time.Duration) bool {
 	wgDone := make(chan bool)
 	defer close(wgDone)
 	go func() {