-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize typedvalues implementation #218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Formalized the httpconv interface to explicit mappers. Supported mappers: text, bytes, json, protobuf, and form-data Renamed Parse-Format to more intuitive Wrap-Unwrap analogy - Implemented Flow as a Protobuf message
Needed because they depend on the types defined in valuetypes init function
We already depended on it, but never explicitely declared is as a dependency. This also updates mergo to the latest version (3.6).
- Further ensured that empty requests/responses are handled properly. - Refactored a couple of references to use the NPE-safe GetXXX implementations.
Now both Fission and Workflows are more stable when it comes to deploying and calling functions near-instantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes long overdue issues with the typedvalues implementation. Due to initial prototyping and initial lack of clear context boundaries, this implementation has been fragile and the source of issues. Also, it's convoluted implementation made it difficult for external contributors to understand.
This PR solves this by redesigning the typedvalues package to be: (1) simple/low complexity (2) make the API less cryptic/more self-explanatory, and (3) more structured when it comes to HTTP parsing and formatting. Towards this end, this change...
Given that this formalization uncovers a lot of unhandled edge cases in the initial fragile implementation, several things were changed besides the typedvalues: