add configurable runtime parameters to chart #165
Conversation
There was a problem hiding this comment.
Hey @xiekeyang - thank you for this very useful PR! Other than a couple of minor issues with the comments, it LGTM 👍
charts/fission-workflows/values.yaml
Outdated
| # Enable Debug Message? | ||
| debug: false | ||
|
|
||
| # pod deleting grace period |
There was a problem hiding this comment.
It probably helps users to add the unit of the period (which is seconds?) to this description.
Something like: # Pod deleting grace period in seconds
`
| runtime: | ||
| image: "{{ .Values.envImage }}:{{.Values.tag}}" | ||
| container: | ||
| command: ["/fission-workflows-bundle"] | ||
| args: [ | ||
| # Only run components related to accessing the API |
There was a problem hiding this comment.
This comment is not true for the workflow environment; could you instead replace it with a description why we override the settings of https://github.com/fission/fission-workflows/blob/master/build/runtime-env/Dockerfile#L21 ?
Something like # Override workflow env CMD to optionally enable --debug
|
@erwinvaneyk Thanks for your review. They are fixed, PTAL. |
|
Thanks @xiekeyang 🎉 |
This is to add configurable runtime parameters, such as grace period, debug enable, to chart.