Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NOBUILD ARG to script #161

Merged
merged 1 commit into from
Jul 6, 2018
Merged

add NOBUILD ARG to script #161

merged 1 commit into from
Jul 6, 2018

Conversation

xiekeyang
Copy link
Contributor

This add a input flag NOBUILD to build/docker.sh, to allow users to build the bundle out of docker build stage.

@xiekeyang
Copy link
Contributor Author

And, it might be clearer to define NOBUILD as bool type.

@erwinvaneyk
Copy link
Member

Hey @xiekeyang 😄thanks for the PR. LGTM 👍

@erwinvaneyk erwinvaneyk merged commit fac0e21 into fission:master Jul 6, 2018
@xiekeyang xiekeyang deleted the nobuild branch July 6, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiekeyang @erwinvaneyk