Include git info in versioning #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the structure in Fission, this change adds git and build info to the
versionpackageIt introduces the following fields:
Versionthe version of the artifact, included by the version generator.GitCommitthe commit of the build, included by the version generator.BuildDatethe date of the build, included by ldflags.GitDatethe date of the commit, included by the version generator.The version struct --- similar to that of Fission --- is a protobuf message to allow it to be passed directly by the apiserver.
As a flyby this also removes a couple of unused messages from the apiserver Protofile.