New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove swagger golang client from the wfcli tool #131

Merged

erwinvaneyk merged 1 commit into master from remove-swagger-golang-client

Mar 22, 2018

Member

erwinvaneyk commented Mar 22, 2018 •

edited

Loading

Before, we used the HTTP client generated with go-swagger in the wfcli. However it has been a nuisance more than a benefit, namely it...

...was bloated code (see the code removed vs added in this PR) without adding much additional functionality.
...had bloated, and cumbersome dependencies. The go-openapi packages are unversioned and have frequent API-breaking changes.
...prevented the reuse of functionality from the server-side (such as validation, event checking), as the generated client also had it is own custom models.

The client that replaces this is a simple http client that simply uses the existing models and does not depend on the go-openapi runtime


          Removed Swagger Golang client in the wfcli tool

33a8438

erwinvaneyk merged commit 02259b5 into master

erwinvaneyk deleted the remove-swagger-golang-client branch

March 22, 2018 12:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet