Add readiness and liveniness probes #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soamvasani
reviewed
Mar 16, 2018
| @@ -35,6 +35,19 @@ spec: | |||
| value: "{{ .Values.fnenv.fission.executor }}.{{ .Values.fnenv.fission.ns }}" | |||
| - name: FNENV_FISSION_CONTROLLER | |||
| value: "{{ .Values.fnenv.fission.controller }}.{{ .Values.fnenv.fission.ns }}" | |||
| readinessProbe: | |||
| httpGet: | |||
| path: "/status" | |||
There was a problem hiding this comment.
Recommend changing this to /healthz for consistency with the rest of the Kubernetes world.
|
Thanks for the quick turnaround @erwinvaneyk, LGTM, just one comment above. |
erwinvaneyk
force-pushed
the
readiness-probe
branch
17 times, most recently
from
277b37d to
fd894c3
Compare
- Update Fission version in dockerfiles
erwinvaneyk
force-pushed
the
readiness-probe
branch
from
fd894c3 to
4d2c0b8
Compare
erwinvaneyk
force-pushed
the
readiness-probe
branch
6 times, most recently
from
6154b08 to
899b33f
Compare
erwinvaneyk
force-pushed
the
readiness-probe
branch
16 times, most recently
from
454b4da to
dfa3fc1
Compare
erwinvaneyk
force-pushed
the
readiness-probe
branch
from
dfa3fc1 to
ad62a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally it updates Fission version in Dockerfile's to ensure that the builder includes the heatlhz endpoint.
Fixes #123