Improve workflow definition #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to simplify the definition of workflows in Golang. The best example of this you can find in the new TestLongRunningWorkflowInvocation test. This test aims to cover the correct execution of parallel branches in a workflow. As the workflow definition in Golang is rather convenient, and to show that YAML doesn't necessarily have to be the only way to define a workflow, this change adds the protobuf parser, which, as it says, simply unmarshals the protobuf into a workflowspec. A metaparser is added to manage parsing files in using one or more of the parsers. This functionality is also added to the parse command in the wfcli.