Extract resolver and parser implementations from workflow api #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These packages did not fit this package, causing unstructured (and potentially cyclic dependencies). This change... - Extracted the parse package to a top-level package as it is a clearly defined component in the system. - Moved the resolver to the fnenv package as all related implementations were already present there. Additionally this change improves the naming and the exposed API of both packages. ResolvedTask has been renamed to FnRef; indicating the immutablity, and function specific nature of this data structure. The format of the FnRef has been formalized to be more or less consistent with the URI standard. The url package was not used to avoid the confusion how the FnRef is used. So instead the fnref implementation currently is a subset of the functionality offered by the url package. The resolver interface has been split into two interfaces: resolver and runtimeResolver. The RuntimeResolver is a runtime-specific resolver. It is not aware of in what runtime context it is being run. The Resolver interface is an abstraction level higher, and is aware of the runtime, in order to resolve a target function to a unique function reference.
erwinvaneyk
force-pushed
the
resolver-parser-improvements
branch
from
67b14a7 to
c625240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages did not fit this package, causing unstructured (and
potentially cyclic dependencies). This change...
defined component in the system.
implementations were already present there.
This change improves the naming and the exposed API of
both packages. ResolvedTask has been renamed to FnRef; indicating the
immutablity, and function specific nature of this data structure. The
format of the FnRef has been formalized to be more or less consistent
with the URI standard. The url package was not used to avoid the
confusion how the FnRef is used. So instead the fnref implementation
currently is a subset of the functionality offered by the url package.
The resolver interface has been split into two interfaces: resolver and
runtimeResolver. The RuntimeResolver is a runtime-specific resolver. It
is not aware of in what runtime context it is being run. The Resolver
interface is an abstraction level higher, and is aware of the runtime,
in order to resolve a target function to a unique function reference.
Additionally this change adds the
-voption to the glide install instructionsto avoid nested vendor issues.