Add improved graph and validation support #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added gonum dependency - Updated a couple of scripts (versions) - Added new validation package in types package
erwinvaneyk
force-pushed
the
graph-gonum
branch
from
1d6ec72 to
45043b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two related packages. First this change introduces a Gonum-based graph implementation for improved performance and easier access to advanced, well-tested graph functionality. In a future PR the implicit graph implementation in the scheduler will be replaced with this one.
Partly using this new graphing support to detect circular dependencies, this PR also adds a new validation package. It aims to replace the existing ad-hoc implementation with a more structured, and consistent API. Likewise, in a future PR the current validation will be replaced with this
validationpackage.