Add input expressions documentation #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinvaneyk
force-pushed
the
docs-input-expressions
branch
from
9f72cd7 to
2d9a3f4
Compare
Copying all data into three different variables is redundant. This commit instead uses a single taskId and a couple of utility functions to achieve the same behaviour. Additionally, this adds necessary documentation to the expr package.
erwinvaneyk
force-pushed
the
docs-input-expressions
branch
from
2d9a3f4 to
77053ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial draft documentation regarding the input expression concept, containing an explanation of the general idea, data model and various examples.
Additionally, it cleans up the expr package a bit. Removing the need for multiple scopes, in favor of a single taskId reference to be passed as a variable to Otto.