Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fnenv.Notifier interface + restructuring of fnenv package #106

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

erwinvaneyk
Copy link
Member

@erwinvaneyk erwinvaneyk commented Feb 12, 2018

  • Added initial interface for the fnenv.Notifier (which will allow the workflow engine to notify environments implementing the interface of future invocations)
  • Re-added the disappeared gofmt and govet checks to the travis config
  • Renamed a couple of variables to idiomatic go
  • Renamed fnenv/test to fnenv/mock to better indicate the purpose of the package.
  • Renamed a couple of files in fnenv to reflect actual contents
  • Moved the fnenv interfaces (runtime, resolver) from the api/function to the fnenv package
  • Added documentation throughout the fnenv package and subpackages.
  • Replaced map with syncmap implementation in Fission Proxy due to potential concurrent read/write issue
  • Moved status shortcuts to the status-struct rather than adding them to the flag field. This eliminates the need for the awkward wi.Status.Status.Completed() in favor of wi.Status.Completed()

@erwinvaneyk erwinvaneyk removed the wip label Feb 12, 2018
@erwinvaneyk erwinvaneyk merged commit d3c45d4 into master Feb 12, 2018
@erwinvaneyk erwinvaneyk deleted the structure-fnenv branch February 12, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant