Merge pull request #199 from xiekeyang/rules

Remove RuleHasCompleted structure
fission · Sep 6, 2018 · 7d5f57a · 7d5f57a
2 parents c5be61b + ff327dd
commit 7d5f57a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/pkg/controller/invocation/controller.go b/pkg/controller/invocation/controller.go
@@ -382,17 +382,20 @@ func defaultPolicy(ctr *Controller) controller.Rule {
 				},
 				Timeout: time.Duration(10) * time.Minute,
 			},
+
 			&controller.RuleExceededErrorCount{
 				OnExceeded: &ActionFail{
 					API: ctr.invocationAPI,
 				},
 				MaxErrorCount: 0,
 			},
-			&RuleHasCompleted{},
+
 			&RuleCheckIfCompleted{
 				InvocationAPI: ctr.invocationAPI,
 			},
+
 			&RuleWorkflowIsReady{},
+
 			&RuleSchedule{
 				Scheduler:     ctr.scheduler,
 				InvocationAPI: ctr.invocationAPI,

diff --git a/pkg/controller/invocation/rules.go b/pkg/controller/invocation/rules.go
@@ -44,17 +44,6 @@ func (ec WfiEvalContext) Invocation() *types.WorkflowInvocation {
 	return ec.wfi
 }
 
-type RuleHasCompleted struct{}
-
-func (cf *RuleHasCompleted) Eval(cec controller.EvalContext) controller.Action {
-	ec := EnsureInvocationContext(cec)
-	wfi := ec.Invocation()
-	if wfi.Status.Finished() {
-		log.Infof("No need to evaluate finished invocation %v", wfi.Metadata.Id)
-	}
-	return nil
-}
-
 type RuleWorkflowIsReady struct {
 }