-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing comma to dbt compile
help text
#2389
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @sethwoodworth |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Thanks for bringing this to our attention @sethwoodworth! I think this message actually predates the existence of "sources" in dbt and the "source" there is referring to the concept of those SQL files as "source code". This is copy-related, so cc @drewbanin - what should this actually say? |
ha - you're right @beckjake - this does predate sources in dbt. Either way though, I think the copy here LGTM :) |
@sethwoodworth if you're able to update the Thanks again for the attention to detail here! |
@drewbanin PR updated with CHANGELOG.md addition 👍 |
I've kicked off the test suite (though it's more of a formality in this PR's case). Once they pass, I'll merge this. Thanks for your contribution @sethwoodworth! |
resolves #2388
Description
Adds a comma to the help text for
dbt compile
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.