Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing comma to dbt compile help text #2389

Merged
merged 4 commits into from
May 4, 2020

Conversation

sethwoodworth
Copy link
Contributor

@sethwoodworth sethwoodworth commented May 1, 2020

resolves #2388

Description

Adds a comma to the help text for dbt compile

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented May 1, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @sethwoodworth

@beckjake
Copy link
Contributor

beckjake commented May 1, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label May 1, 2020
@cla-bot
Copy link

cla-bot bot commented May 1, 2020

The cla-bot has been summoned, and re-checked this pull request!

@beckjake
Copy link
Contributor

beckjake commented May 1, 2020

Thanks for bringing this to our attention @sethwoodworth! I think this message actually predates the existence of "sources" in dbt and the "source" there is referring to the concept of those SQL files as "source code".

This is copy-related, so cc @drewbanin - what should this actually say?

@drewbanin
Copy link
Contributor

ha - you're right @beckjake - this does predate sources in dbt. Either way though, I think the copy here LGTM :)

@drewbanin
Copy link
Contributor

@sethwoodworth if you're able to update the CHANGELOG.md file, we can get this merged! It's a small change, but we want to make sure you get credit for it in the release notes :)

Thanks again for the attention to detail here!

@sethwoodworth
Copy link
Contributor Author

@drewbanin PR updated with CHANGELOG.md addition 👍

@beckjake
Copy link
Contributor

beckjake commented May 4, 2020

I've kicked off the test suite (though it's more of a formality in this PR's case). Once they pass, I'll merge this. Thanks for your contribution @sethwoodworth!

@beckjake beckjake merged commit 58c95bb into dbt-labs:dev/octavius-catto May 4, 2020
@sethwoodworth sethwoodworth deleted the patch-1 branch May 5, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt compile help text is missing a comma
3 participants