-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: adding optional sslmode parameter to postgres connection #2154
Feature: adding optional sslmode parameter to postgres connection #2154
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @dholleran-lendico |
hey @drewbanin , I'm not sure why the CLA check is failing, as I signed it, any ideas? |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Hey @dholleran-lendico, thanks for your contribution! The CLA is a bit of a manual process on our end :) Could you please resolve the merge conflict and while you're at it, include a link to this PR in the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some tiny changes. Thanks for the nice test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionally LGTM if @beckjake is happy with the code!
Nice work on this one @dholleran-lendico - thanks for your contribution to dbt!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I'll merge this now!
resolves #2152
Description
added functionality to add 'sslmode' parameter to a postgres profile connection
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.