Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: adding optional sslmode parameter to postgres connection #2154

Merged

Conversation

0xdholleran
Copy link
Contributor

resolves #2152

Description

added functionality to add 'sslmode' parameter to a postgres profile connection

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Feb 25, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @dholleran-lendico

@0xdholleran
Copy link
Contributor Author

hey @drewbanin , I'm not sure why the CLA check is failing, as I signed it, any ideas?

@beckjake
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Feb 27, 2020
@cla-bot
Copy link

cla-bot bot commented Feb 27, 2020

The cla-bot has been summoned, and re-checked this pull request!

@beckjake
Copy link
Contributor

Hey @dholleran-lendico, thanks for your contribution! The CLA is a bit of a manual process on our end :)

Could you please resolve the merge conflict and while you're at it, include a link to this PR in the changelog?

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some tiny changes. Thanks for the nice test!

CHANGELOG.md Outdated Show resolved Hide resolved
plugins/postgres/dbt/adapters/postgres/connections.py Outdated Show resolved Hide resolved
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionally LGTM if @beckjake is happy with the code!

Nice work on this one @dholleran-lendico - thanks for your contribution to dbt!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I'll merge this now!

@beckjake beckjake merged commit 735ffb3 into dbt-labs:dev/barbara-gittings Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow requiring SSL connections for Postgres/Redshift
3 participants