Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requiring SSL connections for Redshift #3535

Closed
olivermeyer opened this issue Jul 6, 2021 · 4 comments
Closed

Allow requiring SSL connections for Redshift #3535

olivermeyer opened this issue Jul 6, 2021 · 4 comments
Labels
enhancement New feature or request redshift

Comments

@olivermeyer
Copy link

olivermeyer commented Jul 6, 2021

Describe the feature

Many enterprise customers (and their customers) require that connections to databases be encrypted with SSL, and it would be great if dbt supported this.

This issue is a blatant copy-paste of #2152 as the PR merged in that issue only addressed Postgres and not Redshift.

The change should probably be very, very similar to #2154 as the functionality is essentially the same.

Describe alternatives you've considered

Additional context

This feature is relevant for all databases but this issue is about enabling it specifically for Redshift.

Who will this benefit?

Teams that value security.

Are you interested in contributing this feature?

I can give it a try when I have a bit of time. Also happy if someone else takes this over :-)

@olivermeyer olivermeyer added enhancement New feature or request triage labels Jul 6, 2021
@jtcohen6 jtcohen6 added redshift and removed triage labels Jul 6, 2021
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 6, 2021

@olivermeyer Good news! The introduction of sslmode to the Postgres connection keys, in #2154, means you can also use this on Redshift, too. The dbt-redshift adapter plugin directly inherits its connection mechanism from dbt-postgres:

https://github.com/dbt-labs/dbt/blob/e10d1b0f8687152d78d926d9e0337383c4ecdff5/plugins/redshift/dbt/adapters/redshift/connections.py#L38-L65

You should be able to set sslmode to verify-ca/require, and have that take effect for your Redshift connection.

If there's any change needed here, it should be documenting that the Redshift profile has access to all connection parameters available to the Postgres profile, too.

In the meantime, I'm going to close this issue.

@jtcohen6 jtcohen6 closed this as completed Jul 6, 2021
@olivermeyer
Copy link
Author

My bad @jtcohen6, I didn't dig very deep :-) I'm really trying to enforce SSL from dbt Cloud, which I thought would be doable from the UI after fixing this issue, but apparently not. I'll move this to Slack.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 6, 2021

@olivermeyer Understood! I'd recommend reaching out to dbt Cloud support, and indicating that this is an option you'd like to have for Redshift connections, having confirmed that the dbt-redshift plugin already supports it.

@olivermeyer
Copy link
Author

Will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request redshift
Projects
None yet
Development

No branches or pull requests

2 participants