Handle simulcast set target track encoding #154
Conversation
# Conflicts: # android/src/main/java/com/reactnativemembrane/MembraneWebRTC.kt # android/src/main/java/com/reactnativemembrane/RNEndpoint.kt
# Conflicts: # android/build.gradle
example/ios/Podfile
Outdated
| @@ -25,6 +25,7 @@ prepare_react_native_project! | |||
| # } | |||
| # } | |||
| # ``` | |||
| pod 'MembraneRTC', :git => 'https://github.com/jellyfish-dev/membrane-webrtc-ios.git', :branch => 'karkakol/add_simulcast_config_to_endpoints' | |||
There was a problem hiding this comment.
this is ok, just don't forget to remove it before merging
| <string>development</string> | ||
| <key>com.apple.security.application-groups</key> | ||
| <array/> |
There was a problem hiding this comment.
you removed group from here and it's probably going to break screencast in the example
| @@ -35,6 +35,7 @@ export type Track<MetadataType extends Metadata> = { | |||
| vadStatus: VadStatus; | |||
| // Encoding that is currently received. Only present for remote tracks. | |||
| encoding: TrackEncoding | null; | |||
| simulcastConfig: SimulcastConfig | null; | |||
| val videoTracks: HashMap<String, VideoTrack> = hashMapOf(), | ||
| val audioTracks: HashMap<String, AudioTrack> = hashMapOf(), | ||
| val tracksMetadata: HashMap<String, Metadata> = hashMapOf(), | ||
| val tracks: Map<String, TracksAdded.Data.TrackData> = mapOf(), |
There was a problem hiding this comment.
why are there videoTracks, audioTracks and tracks? o.o are they yet another tracks? ;)
There was a problem hiding this comment.
I do not know, it was before, i just adjusted this so it can contain simulcast data
# Conflicts: # ios/MembraneWebRTC.swift # src/index.tsx
example/ios/Podfile.lock
Outdated
There was a problem hiding this comment.
why delete Podfile.lock?
ios/RNEndpoint.swift
Outdated
| self.videoTracks = videoTracks | ||
| self.audioTracks = audioTracks | ||
| self.tracksMetadata = tracksMetadata | ||
| self.tracks = tracks |
There was a problem hiding this comment.
still confusing for me why do we have "videoTracks" "audioTracks" and "tracks" in general
ios/MembraneWebRTC.swift
Outdated
| if trackId == localAudioTrack?.trackId() || | ||
| trackId == localVideoTrack?.trackId() || | ||
| trackId == localScreencastTrack?.trackId(){ |
There was a problem hiding this comment.
you're checking if the given track is local, is there a better way to do this than 3 lines long if?
Allow for operate on target track encodings, changing them