Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC-458 Extend docs #31

Merged
merged 9 commits into from
Feb 21, 2024
Merged

RTC-458 Extend docs #31

merged 9 commits into from
Feb 21, 2024

Conversation

Rados13
Copy link
Contributor

@Rados13 Rados13 commented Feb 16, 2024

No description provided.

@Rados13 Rados13 self-assigned this Feb 16, 2024
@Rados13 Rados13 force-pushed the revisit_docs branch 5 times, most recently from 7bb801a to 8c4af4a Compare February 19, 2024 10:27
@Rados13 Rados13 force-pushed the revisit_docs branch 7 times, most recently from 2abf329 to 686ed8d Compare February 20, 2024 08:43
@Rados13 Rados13 force-pushed the revisit_docs branch 4 times, most recently from 8152e6a to fa2feae Compare February 20, 2024 10:53
@Rados13 Rados13 marked this pull request as ready for review February 20, 2024 11:05
@Rados13 Rados13 requested a review from sgfn February 20, 2024 11:05
Comment on lines 33 to 42
def run_examples():
print("Start examples")
check_exit_code("python ./examples/mini_tutorial.py")
print("After minitutorial")
check_exit_code("python ./examples/room_api.py")
print("After room_api")
check_exit_code("python ./examples/server_notifications.py")
print("All examples run without errors")


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we automate it by running everything from examples? It seems like it will be easy to forget to add new scripts here

@Rados13 Rados13 merged commit 9d81efe into main Feb 21, 2024
6 checks passed
@Rados13 Rados13 deleted the revisit_docs branch February 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants