Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file component #24

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Conversation

roznawsk
Copy link
Member

No description provided.

@roznawsk roznawsk requested review from Rados13 and Karolk99 December 27, 2023 16:57
jellyfish/api/_room_api.py Show resolved Hide resolved
tests/test_room_api.py Outdated Show resolved Hide resolved
@roznawsk roznawsk requested a review from Rados13 December 28, 2023 14:06
component = room_api.get_room(room.id).components[0]

component_file = ComponentFile(
component_file = test_data.component(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be renamed?

README.md Outdated
@@ -98,6 +98,11 @@ You can test the SDK by running
poetry run ci_test
```

In local development you can use
```
poetry run pytest -m "not file_component_sources"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create a poetry script for that something like test.local or something like that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@roznawsk roznawsk merged commit d56495e into main Dec 29, 2023
2 checks passed
@roznawsk roznawsk deleted the RTC-433-file-component-and-hls-subscription branch December 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants