File component framerate #145
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 87.34% 87.52% +0.18%
==========================================
Files 59 59
Lines 1098 1114 +16
==========================================
+ Hits 959 975 +16
Misses 139 139
Continue to review full report in Codecov by Sentry.
|
| ) | ||
|
|
||
| assert model_response(conn, :bad_request, "Error")["errors"] == | ||
| "Invalid request body structure" |
There was a problem hiding this comment.
Why we don't expect to receive "Invalid framerate passed" here?
| framerate: %Schema{ | ||
| type: :integer, | ||
| description: "Framerate of video in a file. It is only valid for video track", | ||
| nullable: true, |
There was a problem hiding this comment.
I think framerate should only be nullable in Options. We expect Jellyfish to set it to some value.
| nullable: true, |
| nullable: true, | ||
| example: 30 |
There was a problem hiding this comment.
Actually, since we publicly declare the default is 30 (in the docs), we can do it here as well.
| nullable: true, | |
| example: 30 | |
| default: 30 |
There was a problem hiding this comment.
I am not sure about that as for FileComponent with audio the default will be nil.
Co-authored-by: Przemysław Rożnawski <[email protected]>
Co-authored-by: Przemysław Rożnawski <[email protected]>
Rados13
force-pushed
the
File-component-framerate
branch
from
d946fd0 to
62f8e6f
Compare
Acknowledging the stipulations set forth:
Docs PR
Elixir SDK PR
Python SDK PR