Skip to content

Commit

Permalink
do 0.10 now
Browse files Browse the repository at this point in the history
  • Loading branch information
@lloydbenson
lloydbenson committed Sep 13, 2015
1 parent 2cd2487 commit e10f2fd
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Fast Intelligent Continous Integration For Node

## getting started

- bin/initialize.sh which will setup nvm and iojs for you.
- bin/initialize.sh which will setup nvm and 0.10 for you.

This comment has been minimized.

Sign in to view

Copy link
@Fishrock123

Fishrock123 Sep 13, 2015

Any reason not to just target 4.0.0 soon?

This comment has been minimized.

Sign in to view

Copy link
@lloydbenson

lloydbenson Sep 13, 2015

Author Contributor

It will be 4.0 soon. Waiting for a few bugs to be worked out in 4.x. @geek 16k payloads issue is the big one.

This comment has been minimized.

Sign in to view

Copy link
@Fishrock123

Fishrock123 Sep 13, 2015

Ah that, yes. It should be fixed in 4.0.1 I think. See: nodejs/node#2844

This comment has been minimized.

Sign in to view

Copy link
@lloydbenson

lloydbenson Sep 13, 2015

Author Contributor

The big reason is that initially I relied on spawnSync and when I went to get rid of that for performance reasons hapi only supported 0.10. Anyway should be resolved shortly. I did submit some build issues I saw and looks like thats being addressed already. nodejs/node#2834.

I am actually running it locally on my laptop with 4.0.0 I notice 3 of the tests failing locally on my linux box (I run fedora 21) on a somewhat slow ultrabook.

The 3 tests that fail are:

575 test-readline-interface.js 60.37 ms
(node) readline.codePointAt is deprecated. Use String.prototype.codePointAt instead.

599 test-repl-require-cache.js 60.42 ms

623 test-stdin-pause-resume-sync.js 60.25 ms
before opening stdin stdin opened pausing stdin opening again pausing again should exit now

I am running make test-ci via Child.spawn. I am guessing 60ms is probably a timeout limit. Is there a way to increase this on my slower machine maybe to see if that helps (or perhaps its a different issue?)

The last question I had is in your jenkins setup, what all platforms do you cover? I am making the assumption you have a farm of some kind that has a slave or more on the OS type. I don't have slave support yet (I am hoping some magic with the new "nes" module under hapi may make this super easy. But wanted to make sure I understood how and what all platforms you are supported for nodejs. I only have a limited supply of OS's at home to test against ;)

This comment has been minimized.

Sign in to view

Copy link
@Fishrock123

Fishrock123 Sep 13, 2015

The 3 tests that fail are:

Having failing node tests on remote machines / ci curcumstances isn't entirely surprising, I can see if I can investigate.

The last question I had is in your jenkins setup, what all platforms do you cover? I am making the assumption you have a farm of some kind that has a slave or more on the OS type.

The node CI has tons of machines: https://ci.nodejs.org/computer/

So uh, yeah this would need to be as robustly cross-platform as possible. :P

This comment has been minimized.

Sign in to view

Copy link
@Fishrock123

Fishrock123 Sep 13, 2015

Specifically-ish:

Windows (2008 & 2012), OS X 10.10, Centos, ubuntu, debian, fedora, freebsd, solaris (smartos), armv7 (wheezy, like beaglebone black), RPi1, RPi2. And soon, some PPC, and maybe AIX machines.

... and yeah there are definitely some platform-specific problems and... interesting behaviors.
- git clone https://github.com/fishin/ficion or npm install ficion
- on a github account (generate a clientId and clientSecret to be used for github integration) - see https://auth0.com/docs/github-clientid.
- Additional pieces of info I used are:
Expand Down
12 changes: 6 additions & 6 deletions bin/initialize.sh
View file
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
#!/bin/bash

IOJS_VERSION="2.5.0"
NODEJS_VERSION="0.10.40"

if [ ! -e ~/.nvm/nvm.sh ];
then
echo "Installing nvm"
curl https://raw.githubusercontent.com/creationix/nvm/v0.24.1/install.sh | bash
else
echo "Looking like you have nvm installed"
echo "nvm installed"
fi

source ~/.nvm/nvm.sh

NODE_VERSION=$(node --version)

if [ "${NODE_VERSION}" != "v${IOJS_VERSION}" ]
if [ "${NODE_VERSION}" != "v${NODEJS_VERSION}" ]
then
echo "Installing iojs"
nvm install iojs-${IOJS_VERSION}
echo "Installing node ${NODEJS_VERSION}"
nvm install ${NODEJS_VERSION}
else
echo "Looks like you have iojs ${IOJS_VERSION} installed"
echo "node ${NODEJS_VERSION} installed"
fi
3 changes: 3 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
"bugs": {
"url": "https://github.com/fishin/ficion/issues"
},
"engines": {
"node": ">=0.10.x"
},
"keywords": [ "ci", "continuous integration", "hapi", "scheduler" ],
"homepage": "https://github.com/fishin/ficion",
"dependencies": {
Expand Down

0 comments on commit e10f2fd

Please sign in to comment.