add key selector argument to replace #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a `-s`/`--key-selector` argument to the `replace` command. in non-regexp mode, it will specify a complete key to match against. in regexp mode, if the key selector yields any matches it will be considered be successful. in this case, replacements will be evaluated against that key-value pair. this pull also fixes two issues: - improper evaluation of the add/remove markup on a line diff during replace - indexes being generated for regexps (index+length) did not match the indexes being generated for substrings (start&end) resulting in a panic for matches longer than half the string
fishi0x01
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a
-s/--key-selectorargument to thereplacecommand. innon-regexp mode, it will specify a complete key to match against. in
regexp mode, if the key selector yields any matches it will be
considered be successful. in this case, replacements will be evaluated
against that key-value pair. the key selector match will also be highlighted
in the display.
this pull also fixes two issues:
replace
indexes being generated for substrings (start&end) resulting in a
panic for matches longer than half the string
after confirmation:
