Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Allow separation of command params with multiple whitespaces #40

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Feature: Allow separation of command params with multiple whitespaces #40

merged 6 commits into from
Jun 16, 2020

Conversation

vikin91
Copy link
Contributor

@vikin91 vikin91 commented Jun 15, 2020

Also:

  • Fix shellcheck warning in run.sh (split export DIR= into two separate lines)
  • Add bats binary auto-discovery (no, this is not enough to make it work on MacOS
  • Uses set -e in run.sh so that single failed test causes failure of entire test suite (and reports it as failure in GH action)

@vikin91
Allow separation of command params with multiple whitespaces
a6ababd 
Fix shellcheck warning in run.sh, add bats binary autodiscovery
fishi0x01
fishi0x01 reviewed Jun 15, 2020
View reviewed changes
Copy link
Owner

@fishi0x01 fishi0x01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you so much!

I have a comment/question about the bats bin reference (see below).

test/run.sh Outdated Show resolved Hide resolved
test/run.sh Show resolved Hide resolved
main.go Show resolved Hide resolved
@fishi0x01 fishi0x01 self-assigned this Jun 15, 2020
@fishi0x01 fishi0x01 added the enhancement New feature or request label Jun 15, 2020
@vikin91
Copy link
Contributor Author

vikin91 commented Jun 16, 2020 •
edited
Loading

~Apparently mv test is failing which was not the case before. I can reproduce it locally, however I am not sure whether my changes caused this? ~

Ok, I got this - should be fixed in the next commit.

fishi0x01
fishi0x01 approved these changes Jun 16, 2020
View reviewed changes
Copy link
Owner

@fishi0x01 fishi0x01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🙇

test/util/util.bash Show resolved Hide resolved
@fishi0x01 fishi0x01 merged commit b70b544 into fishi0x01:master Jun 16, 2020
@vikin91 vikin91 deleted the fix/accept-whitespace-between-params branch June 16, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishi0x01 fishi0x01 fishi0x01 approved these changes

Assignees

@fishi0x01 fishi0x01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikin91 @fishi0x01