Add (very basic) support for replace #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikhorluck
force-pushed
the
feat/replace
branch
from
e276978 to
e216d5b
Compare
18 tasks
ridiculousfish
requested changes
Jun 25, 2023
- There is no reason for the replacement to share lifetime with the subject, because the replacement is not present in the return value, even if no replacement occured
This fixes the following issue in replace_impl: the call to try_reserve passed in a difference of capacities, but try_reserve expects a difference between the desired capacity and the length. Because the initial capacity was nonzero but the length was zero, this caused us to reserve less capacity than we ought to have, leading to an OOB write. Fix this by reworking replace_impl to have less unsafe code. Now we zero initialize the buffer, but we also prefer a stack buffer so we may save an allocation - probably a wash overall. Add a test for this case.
oof, that's on me for not properly testing this, and misreading the documentation. I think I had too much faith in fish's |
|
@ridiculousfish I also think you merged this to the wrong repository, you merged it to https://github.com/ridiculousfish/rust-pcre2 instead of https://github.com/fish-shell/rust-pcre2 |
|
Whoops! Thanks, merged to https://github.com/fish-shell/rust-pcre2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fish-shell/fish-shell#9854