Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten set --show output #6944

Closed
wants to merge 1 commit into from
Closed

Conversation

faho
Copy link
Member

@faho faho commented Apr 25, 2020

Changes it from

$fish_color_user: not set in local scope
$fish_color_user: set in global scope, unexported, with 1 elements
$fish_color_user[1]: length=3 value=|080|
$fish_color_user: set in universal scope, unexported, with 1 elements
$fish_color_user[1]: length=7 value=|brgreen|

(with the trailing empty line - not just a newline)

to

$fish_color_user: set in global scope, unexported, with 1 elements
$fish_color_user[1]: |080|
$fish_color_user: set in universal scope, unexported, with 1 elements
$fish_color_user[1]: |brgreen|

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

Changes it from

```
$fish_color_user: not set in local scope
$fish_color_user: set in global scope, unexported, with 1 elements
$fish_color_user[1]: length=3 value=|080|
$fish_color_user: set in universal scope, unexported, with 1 elements
$fish_color_user[1]: length=7 value=|brgreen|

```

(with the trailing empty line - not just a newline)

to

```
$fish_color_user: set in global scope, unexported, with 1 elements
$fish_color_user[1]: |080|
$fish_color_user: set in universal scope, unexported, with 1 elements
$fish_color_user[1]: |brgreen|
```
@faho faho added this to the fish 3.2.0 milestone Apr 25, 2020
@faho
Copy link
Member Author

faho commented Apr 26, 2020

Merged as 6990c44

@faho faho closed this Apr 26, 2020
@zanchey
Copy link
Member

zanchey commented Apr 26, 2020

Docs need updating here

@zanchey zanchey added the docs An issue/PR that touches or should touch the docs label Apr 26, 2020
faho added a commit that referenced this pull request Apr 26, 2020
faho added a commit that referenced this pull request Apr 26, 2020
@faho
Copy link
Member Author

faho commented Apr 26, 2020

Docs (and translations) have been updated. Surprised me that we'd describe this output.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2020
@faho faho deleted the shorter-show branch September 23, 2021 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs An issue/PR that touches or should touch the docs enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants