Support for Sanguino/Melzi, e.g. Creality Ender-3 #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boards.h
Outdated
| #define IS_PIN_SERVO(p) ((p) >= 0 && (p) < MAX_SERVOS) | ||
| #define IS_PIN_I2C(p) ((p) == 16 || (p) == 17) | ||
| #define IS_PIN_SPI(p) ((p) == SS || (p) == MOSI || (p) == MISO || (p) == SCK) | ||
| #define IS_PIN_SERIAL(p) ((p) == 8 || (p) == 9 || (p) == 10 || (p) == 11) |
There was a problem hiding this comment.
This should only include pins 8 & 9 for now unless PIN_SERIAL2_RX and PIN_SERIAL2_TX are defined in the variants file for the Sanguino/Melzi.
There was a problem hiding this comment.
oops, overlooked. thanks for catching it
Boards.h
Outdated
| @@ -603,7 +603,7 @@ writePort(port, value, bitmask): Write an 8 bit port. | |||
| #define IS_PIN_SERVO(p) ((p) >= 0 && (p) < MAX_SERVOS) | |||
| #define IS_PIN_I2C(p) ((p) == 16 || (p) == 17) | |||
| #define IS_PIN_SPI(p) ((p) == SS || (p) == MOSI || (p) == MISO || (p) == SCK) | |||
| #define IS_PIN_SERIAL(p) ((p) == 8 || (p) == 9 || (p) == 10 || (p) == 11) | |||
| #define IS_PIN_SERIAL(p) ((p) == 8 || (p) == 9 | |||
There was a problem hiding this comment.
Missing a closing paren. Please squash the commits after adding the paren if you're comfortable doing that.
brandstaetter
force-pushed
the
Sanguino_ATmega1284P
branch
from
ea089cc to
f3fef2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue when compiling Marlin v2 for the Creality Ender-3
See also #281