Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue after arm none eabi gcc update #437

Closed
fpistm opened this issue Dec 9, 2019 · 0 comments · Fixed by #438
Closed

Build issue after arm none eabi gcc update #437

fpistm opened this issue Dec 9, 2019 · 0 comments · Fixed by #438

Comments

@fpistm
Copy link
Contributor

fpistm commented Dec 9, 2019

Hi,

I've updated the arm none eabi gcc toolchain used by the STM32 core to the v9.2.1.
I've built all Arduino built-in example without any issue except those for Firmata, see the error hereafter:

Firmata/Firmata.h:131:17: error: friend declaration of 'void encodeByteStream(size_t, uint8_t*, size_t) const' specifies default arguments and isn't a definition [-fpermissive]
  131 |     friend void FirmataMarshaller::encodeByteStream (size_t bytec, uint8_t * bytev, size_t max_bytes = 0) const;
      |                 ^~~~~~~~~~~~~~~~~

As specified by the compiler output, error comes from the default argument here:

friend void FirmataMarshaller::encodeByteStream (size_t bytec, uint8_t * bytev, size_t max_bytes = 0) const;

As it is also specified here:

void encodeByteStream (size_t bytec, uint8_t * bytev, size_t max_bytes = 0) const;

I guess it could be removed from the friend declaration as already declare in FirmataMarshaller.h

Ref:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2000/n1263.html

dasdgw added a commit to dasdgw/FirmataExpress that referenced this issue Jul 18, 2020
in firmata this was already fixed:
firmata/arduino#437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant